Explicit TLS config #237
Merged
Explicit TLS config #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 39.82% 44.04% +4.21%
==========================================
Files 116 116
Lines 9413 9474 +61
==========================================
+ Hits 3749 4173 +424
+ Misses 5664 5301 -363
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fabianfett
commented
Feb 28, 2022
Comment on lines
+27
to
+49
| struct TLS { | ||
| enum Base { | ||
| case disable | ||
| case prefer(NIOSSLContext) | ||
| case require(NIOSSLContext) | ||
| } | ||
|
|
||
| var base: Base | ||
|
|
||
| private init(_ base: Base) { | ||
| self.base = base | ||
| } | ||
|
|
||
| static var disable: Self = Self.init(.disable) | ||
|
|
||
| static func prefer(_ sslContext: NIOSSLContext) -> Self { | ||
| self.init(.prefer(sslContext)) | ||
| } | ||
|
|
||
| static func require(_ sslContext: NIOSSLContext) -> Self { | ||
| self.init(.require(sslContext)) | ||
| } | ||
| } |
There was a problem hiding this comment.
@gwynne This will become public API eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently users provide a TLSConfiguration to the PSQLConnection.Configuration to signal they want to require TLS. This is very implicit and it will create a new
NIOSSLContextfor every new connection (VERY, VERY expensive operation).Changes
PSQLConnection.Configuration. The initial provided values are.disable,.prefer,.require.preferor.requirethey must provide a NIOSSLContextResult