Skip to content

Add Sendable checking #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Conversation

fabianfett
Copy link
Collaborator

@fabianfett fabianfett commented Mar 3, 2022

Motivation

For Swift 5.6 we want to add Sendable checking

Changes

  • Add Sendable protocol requirement where needed.

Result

Safer code for anyone.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #242 (24622b4) into main (495dec9) will increase coverage by 4.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   39.57%   43.61%   +4.03%     
==========================================
  Files         115      115              
  Lines        9479     9486       +7     
==========================================
+ Hits         3751     4137     +386     
+ Misses       5728     5349     -379     
Flag Coverage Δ
unittests 43.61% <ø> (+4.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/PostgresNIO/Connection/PostgresConnection.swift 11.83% <ø> (+0.75%) ⬆️
Sources/PostgresNIO/Data/PostgresData.swift 6.89% <ø> (ø)
Sources/PostgresNIO/Data/PostgresDataType.swift 58.49% <ø> (+41.50%) ⬆️
Sources/PostgresNIO/Data/PostgresRow.swift 50.00% <ø> (+1.02%) ⬆️
...rces/PostgresNIO/New/Messages/RowDescription.swift 100.00% <ø> (ø)
Sources/PostgresNIO/New/PSQLRowStream.swift 84.54% <ø> (+6.96%) ⬆️
Sources/PostgresNIO/New/PostgresCell.swift 96.77% <ø> (+3.22%) ⬆️
...ces/PostgresNIO/New/PostgresRow-multi-decode.swift 4.44% <0.00%> (+0.19%) ⬆️
... and 27 more

@fabianfett fabianfett requested a review from gwynne March 4, 2022 07:42
@fabianfett fabianfett marked this pull request as ready for review March 4, 2022 07:42
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a start 😉

@fabianfett fabianfett merged commit c54c006 into vapor:main Mar 6, 2022
@fabianfett fabianfett deleted the ff-fix-sendable-postgres branch March 6, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants