Skip to content

README update for async/await #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 11, 2022
Merged

Conversation

fabianfett
Copy link
Collaborator

See Title.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #254 (5d9df4f) into main (7f290f2) will increase coverage by 4.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   39.78%   43.82%   +4.03%     
==========================================
  Files         115      115              
  Lines        9513     9520       +7     
==========================================
+ Hits         3785     4172     +387     
+ Misses       5728     5348     -380     
Flag Coverage Δ
unittests 43.82% <ø> (+4.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ces/PostgresNIO/New/PostgresRow-multi-decode.swift 4.44% <0.00%> (+0.19%) ⬆️
...es/PostgresNIO/Connection/PostgresConnection.swift 17.48% <0.00%> (+0.93%) ⬆️
Sources/PostgresNIO/Data/PostgresRow.swift 50.00% <0.00%> (+1.02%) ⬆️
...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift 19.60% <0.00%> (+1.42%) ⬆️
...s/PostgresNIO/New/Data/Array+PostgresCodable.swift 93.25% <0.00%> (+2.24%) ⬆️
...ostgresNIO/Deprecated/PostgresMessageDecoder.swift 95.45% <0.00%> (+2.27%) ⬆️
...ostgresNIO/New/PostgresBackendMessageDecoder.swift 93.28% <0.00%> (+2.98%) ⬆️
...urces/PostgresNIO/New/Messages/ErrorResponse.swift 32.30% <0.00%> (+3.07%) ⬆️
Sources/PostgresNIO/New/PostgresCell.swift 96.77% <0.00%> (+3.22%) ⬆️
...s/PostgresNIO/New/Data/Float+PostgresCodable.swift 76.66% <0.00%> (+3.33%) ⬆️
... and 20 more

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots and lots of grammar and phrasing nits, but only one actual major content note (you'll know it when you see it 😉). Overall, I love it!

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like fixing the whitespace nits please do, if you don't want to bother I don't care that much. I love the heck out of this!

@fabianfett fabianfett merged commit 93a928d into vapor:main Mar 11, 2022
@fabianfett fabianfett deleted the ff-README-update branch March 11, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants