-
-
Notifications
You must be signed in to change notification settings - Fork 82
README update for async/await #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #254 +/- ##
==========================================
+ Coverage 39.78% 43.82% +4.03%
==========================================
Files 115 115
Lines 9513 9520 +7
==========================================
+ Hits 3785 4172 +387
+ Misses 5728 5348 -380
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots and lots of grammar and phrasing nits, but only one actual major content note (you'll know it when you see it 😉). Overall, I love it!
Co-authored-by: Gwynne Raskind <[email protected]>
2c20230
to
4dd869e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you feel like fixing the whitespace nits please do, if you don't want to bother I don't care that much. I love the heck out of this!
See Title.