Allow unsafe raw SQL injection in PostgresQuery #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-allow-unsafe-raw-sql-injection
branch
from
284ce3b to
c1e28eb
Compare
Codecov Report
@@ Coverage Diff @@
## main #258 +/- ##
==========================================
+ Coverage 39.78% 43.84% +4.05%
==========================================
Files 115 115
Lines 9513 9523 +10
==========================================
+ Hits 3785 4175 +390
+ Misses 5728 5348 -380
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gwynne
requested changes
Mar 12, 2022
fabianfett
force-pushed
the
ff-allow-unsafe-raw-sql-injection
branch
from
c1e28eb to
912b9ae
Compare
fabianfett
force-pushed
the
ff-allow-unsafe-raw-sql-injection
branch
from
912b9ae to
13eec94
Compare
gwynne
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes developers want to have the freedom to inject values into a PostgresQuery that are not bindable. Examples for this can be tableNames or columnNames.
Changes
Result
More use-cases covered. Make unsafe code explicit unsafe.
Open question
What is the best unsafe marker word? Right now I have
unsafeSQLInjection. I like this because it makes potential users google for SQL injection... This is rather long. Other previously discussed options are:raw,unsafeRaw.