-
-
Notifications
You must be signed in to change notification settings - Fork 82
Fix CI test link in README #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #260 +/- ##
==========================================
+ Coverage 39.78% 43.82% +4.03%
==========================================
Files 115 115
Lines 9513 9520 +7
==========================================
+ Hits 3785 4172 +387
+ Misses 5728 5348 -380
Flags with carried forward coverage won't be shown. Click here to find out more.
|
README.md
Outdated
<a href="https://github.com/vapor/postgres-nio/actions"> | ||
<img src="https://github.com/vapor/postgres-nio/workflows/test/badge.svg" alt="Continuous Integration"> | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href="https://github.com/vapor/postgres-nio/actions/workflows/main-codecov.yml">
<img src="https://github.com/vapor/postgres-nio/actions/workflows/main-codecov.yml/badge.svg?branch=main&event=push" alt="Continuous Integration">
</a>
The badge will reflect the status of the most recent code coverage update run made against main
, which happens whenever a PR is merged - that's the most accurate representation of "CI status" there is for the current CI setup. (And, of course, I have major plans around improving the CI across the board anyway 🙂)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Oh, for reference, since I had to hunt it down again myself just now - to get the badge URL for a workflow, go to the Actions tab, select the workflow on the left, and click the ellipsis "…" button to the right of the search field to get a dropdown with a "Create status badge" option. So easy to find! 🙃)
Includes a larger number of Swift versions tested against and the updated code coverage reporting action. Also renames the workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hereby approve all these changes that I made all by myself 🤣
(But even if it was 100% me, I still wouldn't have made them without @fabianfett's suggestions ❤️)
Fix CI test link in README