Skip to content

Use Int(exactly:) instead of restricting to 64 bit platforms #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

fabianfett
Copy link
Collaborator

Fixes #199. cc @weissi

@fabianfett fabianfett requested a review from gwynne March 16, 2022 08:38
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #267 (e3a524a) into main (f11cc9b) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   43.84%   43.87%   +0.03%     
==========================================
  Files         115      115              
  Lines        9523     9516       -7     
==========================================
  Hits         4175     4175              
+ Misses       5348     5341       -7     
Flag Coverage Δ
unittests 43.87% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/PostgresNIO/Data/PostgresData+Int.swift 0.00% <0.00%> (ø)

Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@fabianfett fabianfett added this to the 1.9.0 milestone Mar 16, 2022
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Win. Made a very similar change in MySQLNIO recently; Tanner was really way too willing to just crash everything at the slightest provocation 🤦‍♀️

@fabianfett fabianfett merged commit c72516d into vapor:main Mar 18, 2022
@fabianfett fabianfett deleted the ff-fix-issue-199 branch March 18, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should use the Int(exactly:) constructor instead of restricting itself to 64 bit platforms
4 participants