Use provided logger consistently in PostgresConnection.send(_:logger:)

[gwynne]

Probably affects no one whatsoever, since using a non-default logger per-query isn't actually implemented anywhere that I've seen, but might as well be consistent just the same.

[codecov-commenter]

Codecov Report

Merging #299 (7089855) into main (2fa1cb1) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   43.91%   43.91%           
=======================================
  Files         115      115           
  Lines        9680     9680           
=======================================
  Hits         4251     4251           
  Misses       5429     5429           

Flag	Coverage Δ
unittests	43.91% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/PostgresNIO/Connection/PostgresConnection.swift	17.14% <0.00%> (ø)

[fabianfett]

I'm pretty sure this is not needed.

postgres-nio/Sources/PostgresNIO/Connection/PostgresDatabase+PreparedQuery.swift

Line 8 in 2fa1cb1

return self.send(PostgresCommands.prepareQuery(request: request), logger: self.logger).map { _ in

[gwynne]

@fabianfett It's less about whether it's actually needed and more about being consistent with the usage elsewhere in the same method 🤷‍♀️. I mean, at the end of the day, there's no reason that the send methods of all the Fluent drivers take a logger parameter to begin with; nothing ever passes anything other than the existing logger to that parameter, it's not exposed to any of the higher layers, and it's not required by any protocol. It's just another of the weird warts on Fluent's API design. (And furthermore, on general principle of crabbiness, I accuse Mongo of being at fault, despite having made no effort whatsoever to find evidence to that effect 😆.)

That all being said, why not be consistent?

[fabianfett]

I'm stupid. You are right...