Skip to content

Fix new NIO warnings #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

fabianfett
Copy link
Collaborator

This PR brings us up to speed with current Swift NIO main branch and fixes the warnings that will show up once a new NIO release is cut.

@fabianfett fabianfett requested a review from gwynne July 7, 2022 10:32
@fabianfett fabianfett marked this pull request as draft July 7, 2022 10:32
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #300 (b73c4b6) into main (4b8ec14) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   43.91%   43.91%           
=======================================
  Files         115      115           
  Lines        9680     9680           
=======================================
  Hits         4251     4251           
  Misses       5429     5429           
Flag Coverage Δ
unittests 43.91% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/PostgresNIO/Connection/PostgresConnection.swift 17.14% <0.00%> (ø)
Sources/PostgresNIO/Data/PostgresData.swift 6.89% <ø> (ø)
Sources/PostgresNIO/Data/PostgresRow.swift 49.24% <ø> (ø)
Sources/PostgresNIO/New/Messages/DataRow.swift 95.38% <ø> (ø)
Sources/PostgresNIO/New/PostgresCell.swift 96.77% <ø> (ø)

@fabianfett fabianfett force-pushed the ff-fix-new-nio-warnings branch from b73c4b6 to 60aa4db Compare July 7, 2022 11:01
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

@fabianfett fabianfett marked this pull request as ready for review August 25, 2022 15:38
@fabianfett fabianfett merged commit 08226c5 into vapor:main Sep 27, 2022
@fabianfett fabianfett deleted the ff-fix-new-nio-warnings branch September 27, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants