Update test CI #306
Merged
Update test CI #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostgres-nio into mahdibm-update-test-ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 43.90% 43.94% +0.03%
==========================================
Files 115 115
Lines 9677 9670 -7
==========================================
Hits 4249 4249
+ Misses 5428 5421 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gwynne
requested changes
Oct 3, 2022
.github/workflows/test.yml
Outdated
| @@ -29,7 +27,8 @@ jobs: | |||
| - name: Run unit tests with code coverage and Thread Sanitizer | |||
| run: swift test --enable-test-discovery --filter=^PostgresNIOTests --sanitize=thread --enable-code-coverage | |||
| - name: Submit coverage report to Codecov.io | |||
| uses: vapor/[email protected] | |||
| if: "!contains(matrix.container, 'nightly')" | |||
| uses: vapor/[email protected] | |||
There was a problem hiding this comment.
The v0.2 tag points to the latest "0.2.x" version, not 0.2.0; it has the effect of SPM's upToNextMinor(), very much on purpose, please keep it that way 🙂
| - focal | ||
| container: ${{ format('{0}-{1}', matrix.swift, matrix.os) }} | ||
| container: | ||
| - swift:5.5-bionic |
There was a problem hiding this comment.
What is the benefit to testing on bionic?
There was a problem hiding this comment.
We have a nice mix of oses and swift versions... Swift 5.7 also still supports bionic.
gwynne
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test CI could use a bit of an update :)
NIO
has recently droppedwill soon drop support for swift 5.4, so we should drop swift 5.4 too.This also updates integration-tests and api-breakage jobs to use swift 5.7.
EDIT 1:
Now this PR also removes the codecov checks from nightly builds because codecov doesn't seem to get along with nightlies.