Skip to content

Add docs outlining changes we made to PostgresRow/column(name:) #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

fabianfett
Copy link
Collaborator

Added a doc that describes how to best migrate to the newer and better PostgresRow cell access API. While at it also opened up some convenience API's that make dealing with it much nicer.

@fabianfett fabianfett requested review from gwynne and 0xTim October 7, 2022 12:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #312 (6576e77) into main (a12d09f) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   43.53%   43.52%   -0.02%     
==========================================
  Files         115      115              
  Lines        9760     9763       +3     
==========================================
  Hits         4249     4249              
- Misses       5511     5514       +3     
Flag Coverage Δ
unittests 43.52% <40.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/PostgresNIO/New/PostgresCell.swift 88.23% <25.00%> (-8.54%) ⬇️
Sources/PostgresNIO/Data/PostgresRow.swift 49.24% <100.00%> (ø)

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few typos and nits

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@fabianfett fabianfett merged commit c2cdd47 into vapor:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants