Skip to content

AsyncStreamConsumer should stream DataRows. #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

AsyncStreamConsumer should stream DataRows. #316

merged 1 commit into from
Oct 26, 2022

Conversation

fabianfett
Copy link
Collaborator

Motivation

We want to replace our AsyncStreamConsumer implementation with the new NIOThrowingAsyncSequenceProducer. To do this we must ensure that the producing and consuming side of our AsyncSequence operate on the same type.

Changes

  • Create the PostgresRow later

gwynne
gwynne approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianfett fabianfett merged commit ab1fc3c into vapor:main Oct 26, 2022
@fabianfett fabianfett deleted the ff-nio-async-sequence branch October 26, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @gwynne