Skip to content

Use NIOFoundationCompat for UUID <-> ByteBuffer #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2022
Merged

Use NIOFoundationCompat for UUID <-> ByteBuffer #319

merged 1 commit into from
Nov 3, 2022

Conversation

fabianfett
Copy link
Collaborator

@fabianfett fabianfett commented Nov 3, 2022 •
edited
Loading

Motivation

NIOFoundationCompat has added methods to read and write UUID from/to ByteBuffers. We like to maintain less code.

Changes

  • Use methods from NIOFoundationCompat to read and write UUID from/to ByteBuffers
  • Require NIO 2.44.0

Result

Less code to maintain.

@fabianfett fabianfett merged commit ee024b7 into vapor:main Nov 3, 2022
@fabianfett fabianfett deleted the ff-use-nio-methods-for-uuid-coding branch November 3, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @glbrntt @0xTim