Skip to content

fix en- and decoding of NULL values in arrays #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

ehpi
Copy link
Contributor

@ehpi ehpi commented Nov 13, 2022

Fixes #323

Fixes the en- and decoding of arrays containing NULL values.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #324 (91e32ca) into main (3a16650) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   41.62%   41.62%           
=======================================
  Files         115      115           
  Lines        9377     9377           
=======================================
  Hits         3903     3903           
  Misses       5474     5474           
Flag Coverage Δ
unittests 41.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/PostgresNIO/Data/PostgresData+Array.swift 0.00% <0.00%> (ø)

Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks!

@fabianfett fabianfett merged commit b5cca72 into vapor:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrays with NULL values get encoded/decoded incorrectly
3 participants