Skip to content

Update API Docs Workflow #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2023
Merged

Update API Docs Workflow #329

merged 4 commits into from
Feb 20, 2023

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Feb 19, 2023

The API docs workflow is now working so we can roll this out.

Because of the way exporting works on Linux and how DocC consumes it, I've ensured everything compiles when nothing is exported and wrapped the exports in our DocC flag

@0xTim 0xTim requested review from fabianfett and gwynne February 19, 2023 04:27
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Merging #329 (36098eb) into main (521b6b4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   41.54%   41.54%           
=======================================
  Files         115      115           
  Lines        9436     9436           
=======================================
  Hits         3920     3920           
  Misses       5516     5516           
Flag Coverage Δ
unittests 41.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/PostgresNIO/New/PSQLFrontendMessageEncoder.swift 100.00% <ø> (ø)
...ostgresNIO/New/PostgresBackendMessageDecoder.swift 94.02% <ø> (ø)
Sources/PostgresNIO/New/PostgresQuery.swift 75.00% <ø> (ø)
...es/PostgresNIO/Utilities/PostgresJSONDecoder.swift 0.00% <ø> (ø)
...es/PostgresNIO/Utilities/PostgresJSONEncoder.swift 0.00% <ø> (ø)

Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@fabianfett fabianfett merged commit 7a816db into main Feb 20, 2023
@fabianfett fabianfett deleted the api-docs branch February 20, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants