Fix Decodable autoconformance to PostgresDecodable #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
approved these changes
Mar 12, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
=======================================
Coverage 41.54% 41.54%
=======================================
Files 115 115
Lines 9436 9436
=======================================
Hits 3920 3920
Misses 5516 5516
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation of
PostgresDecodableonDecodabletypes does not work automatically when used in other packages because it's not public. Just a simple visibility change does fix this.