Drop support for Swift 5.5 #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
approved these changes
Apr 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
- Coverage 41.61% 41.57% -0.04%
==========================================
Files 115 115
Lines 9440 9434 -6
==========================================
- Hits 3928 3922 -6
Misses 5512 5512
|
|
nightly crashes the compiler... ignore. |
|
Yeah this is being tracked at swiftlang/swift#65064 (assuming it's the same as all the other nightly crashes we're seeing across Vapor) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@gwynne started to drop Swift 5.5 in #335. However a lot of code that we can remove now wasn't touched there. And it should not be touched in there. This PR removes all code that we can drop when requiring Swift 5.6.
Changes