Fixes crash in queries that timeout #351
Conversation
| let rowStream = self.rowStream! | ||
| self.rowStream = nil | ||
| rowStream.receive(completion: .failure(error)) |
There was a problem hiding this comment.
Reentrancy bugs are the best!
There was a problem hiding this comment.
Thanks @fabianfett ! But now a got a different error 😃 :
PostgresNIO/PostgresChannelHandler.swift:276: Fatal error: Unexpectedly found nil while unwrapping an Optional value
I hope that I can free up some time later today and have a look.
BTW is there a good way to see what query is currently running on the connection?
There was a problem hiding this comment.
Lovely. Can you get me another repro? Happy to fix that one for you as well?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 41.20% 41.19% -0.01%
==========================================
Files 117 117
Lines 9657 9658 +1
==========================================
Hits 3979 3979
- Misses 5678 5679 +1
|
Fixes #347.
In an ideal case I add a unit test for this as well, but sadly this is rather involved.
cc @trasch.