Skip to content

Fixup code coverage config in CI #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2023
Merged

Fixup code coverage config in CI #362

merged 1 commit into from
May 6, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 6, 2023

  • swift-codecov-action now works around the Swift 5.8 problem
  • We don't want the unittests flag or need verbose output
  • We shouldn't fail CI if coverage uploads fail (it happens often)

…e Swift 5.8 problem, we don't want the unittests flag or need verbose output, and we shouldn't fail CI if uploads fail (they fail often)
@gwynne gwynne requested review from fabianfett and 0xTim May 6, 2023 05:51
@gwynne gwynne self-assigned this May 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #362 (0ed1d77) into main (e4cc928) will decrease coverage by 0.52%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   42.51%   41.99%   -0.52%     
==========================================
  Files         117      117              
  Lines        9694     8091    -1603     
==========================================
- Hits         4121     3398     -723     
+ Misses       5573     4693     -880     

see 117 files with indirect coverage changes

@gwynne gwynne merged commit dbefcb0 into main May 6, 2023
@gwynne gwynne deleted the code-coverage-fixup branch May 6, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants