Decode .bpchar as String
#368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aracter(N)` (the auto-padded form of `character varying`). `String`'s `PostgresCodable` conformance should thus recognize it.
fabianfett
approved these changes
May 11, 2023
gwynne
force-pushed
the
add-bpchar-decoding-support
branch
from
a385bba to
4b61b73
Compare
…a string, for pity's sake.
gwynne
force-pushed
the
add-bpchar-decoding-support
branch
from
670f66a to
19dbc08
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
=======================================
Coverage 42.97% 42.98%
=======================================
Files 118 118
Lines 8242 8243 +1
=======================================
+ Hits 3542 3543 +1
Misses 4700 4700
|
|
Any chance this could be released soon? We would like to get the CVE fix, but this broke our app. Thanks! |
|
@michal-tomlein We just released 1.15.0, which includes this fix, thanks for the nudge! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpcharis "blank-padded char", the low-level Postgres name forcharacter(N)(the auto-padded form ofcharacter varying).String'sPostgresCodableconformance should thus recognize it as a valid representation.