PostgresFrontendMessage: refactor encoding #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
- Coverage 44.44% 43.88% -0.57%
==========================================
Files 118 107 -11
Lines 8639 8596 -43
==========================================
- Hits 3840 3772 -68
- Misses 4799 4824 +25
|
gwynne
approved these changes
Aug 4, 2023
fabianfett
force-pushed
the
ff-refactor-encoding
branch
from
70eb3c8 to
93ca9c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use an explicit
PostgresFrontendMessagewhen we encode those messages into the outgoing ByteBuffer. However this can be wasteful if we need to transform the data that we have to explicitly match thePostgresFrontendMessagetype. We should instead have methods on the Encoder that match the message types. This patch achieves exactly this.