Skip to content

Move PostgresFrontendMessage to tests #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

fabianfett
Copy link
Collaborator

We should remove everything that we don't need from PostgresNIO. PostgresFrontendMessage is only required in tests now. So let's move it to tests.

@fabianfett fabianfett added the semver-patch No public API change. label Aug 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #399 (8e69f43) into main (12584c6) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage   49.14%   49.10%   -0.05%     
==========================================
  Files         109      108       -1     
  Lines        8934     8845      -89     
==========================================
- Hits         4391     4343      -48     
+ Misses       4543     4502      -41     
Files Changed Coverage Δ
...s/PostgresNIO/New/Extensions/ByteBuffer+PSQL.swift 100.00% <ø> (ø)
...stgresNIO/New/PostgresFrontendMessageEncoder.swift 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@fabianfett fabianfett merged commit 9a02d74 into vapor:main Aug 19, 2023
@fabianfett fabianfett deleted the ff-move-stuff-out-of-PostgresNIO branch August 19, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants