Remove PSQLError.Code.clientClosesConnection #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
commented
Aug 19, 2023
| @@ -25,8 +25,7 @@ class PostgresChannelHandlerTests: XCTestCase { | |||
| handler | |||
| ], loop: self.eventLoop) | |||
| defer { | |||
| do { try embedded.finish() } | |||
| catch { print("\(String(reflecting: error))") } | |||
| XCTAssertNoThrow({ try embedded.finish() }) | |||
There was a problem hiding this comment.
this tests finally works correctly again.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
+ Coverage 48.97% 49.15% +0.18%
==========================================
Files 108 108
Lines 8845 8839 -6
==========================================
+ Hits 4332 4345 +13
+ Misses 4513 4494 -19
|
|
Expected API break detected by CI: |
gwynne
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #383. This has breaking change which is fine, since we haven't cut a release after #383, which introduces the error code that we remove now.