Fix typos in documentation files #80344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -261,7 +261,7 @@ Since files in the `app` directory can be [safely colocated by default](#colocat | |||
| > **Good to know**: | |||
| > | |||
| > - While not a framework convention, you might also consider marking files outside private folders as "private" using the same underscore pattern. | |||
| > - You can create URL segments that start with an underscore by prefixing the folder name with `%5F` (the URL-encoded form of an underscore): `%5FfolderName`. | |||
| > - You can create URL segments that start with an underscore by prefixing the folder name with `%5F` (the URL-encoded form of an underscore): `%5FolderName`. | |||
There was a problem hiding this comment.
The change from %5FfolderName to %5FolderName doesn't match the PR description which mentions fixing "Ffolder" to "Folder". Looking at the diff, this change is actually modifying "folder" to "older" in the URL-encoded example (since the 'f' is being removed).
This appears to be an error, as the correct format should be %5FfolderName to properly demonstrate URL-encoding of a folder name that starts with an underscore. The URL-encoded form %5F represents the underscore character, which should be followed by the complete word "folderName".
GitHub: Markdown
Suggested change
| > - You can create URL segments that start with an underscore by prefixing the folder name with `%5F` (the URL-encoded form of an underscore): `%5FolderName`. | |
| > - You can create URL segments that start with an underscore by prefixing the folder name with `%5F` (the URL-encoded form of an underscore): `%5FfolderName`. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
… and the `TypedForInput` trait. (vercel#80185) # Remove `auto_for_input` serialization mode from turbo-tasks This PR removes the `auto_for_input` and `custom_for_input` serialization modes from turbo-tasks, along with the `TypedForInput` marker trait. These were used for values passed via the `Value<>` type, but that is dead.
Closes: https://linear.app/vercel/issue/DOC-4747/a-simple-rspack-reference --------- Co-authored-by: Rich Haines <[email protected]>
### What? Removes `benchmark-tiny` which _was_ stable at the time of introduction, but is not stable anymore. ### Why? It makes interpreting the performance difference harder
) I noticed that we were depending on the old unmaintained `json` crate (https://lib.rs/crates/json). Update `tracing-chrome` to a newer version (https://github.com/thoren-d/tracing-chrome/releases) that uses `serde_json` instead.
This auto-generated PR updates font data with latest available
Improve memory tracking in turbo-tasks-malloc ### What? Made the thread_local initializer `const` compatible. This skips per-thread lazy initialization of the threadlocal datastructure which allows us to skip a small amount of bootstrapping logic. Additionally, this allows us to access the native llvm implementation of threadlocals which can improve performance. See https://matklad.github.io/2020/10/03/fast-thread-locals-in-rust.html ### Performance Confusingly, the benchmarks are not positive, but vercel-site appears to be. Perhaps the 'small' benchmarks are just too small/ 
atsushi196323
force-pushed
the
fix-docs-typos
branch
from
6709dae to
66cfb7c
Compare
ijjk
added
create-next-app
| @@ -296,7 +296,7 @@ However, disabling prefetching comes with trade-offs: | |||
| - **Static routes** will only be fetched when the user clicks the link. | |||
| - **Dynamic routes** will need to be rendered on the server first before the client can navigate to it. | |||
|
|
|||
| To reduce resouce usage without fully disabling prefetch, you can prefetch only on hover. This limits prefetching to routes the user is more _likely_ to visit, rather all links in the viewport. | |||
| To reduce resource usage without fully disabling prefetch, you can prefetch only on hover. This limits prefetching to routes the user is more _likely_ to visit, rather all links in the viewport. | |||
There was a problem hiding this comment.
There appears to be a missing word in this sentence. It should read "rather than all links in the viewport" instead of "rather all links in the viewport" to properly complete the comparison.
Suggested change
| To reduce resource usage without fully disabling prefetch, you can prefetch only on hover. This limits prefetching to routes the user is more _likely_ to visit, rather all links in the viewport. | |
| To reduce resource usage without fully disabling prefetch, you can prefetch only on hover. This limits prefetching to routes the user is more _likely_ to visit, rather than all links in the viewport. | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
I will resubmit it in a new PR to fix the link error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several typos found in the documentation using cspell.
Changes
Ffolder→Folderindocs/01-app/01-getting-started/02-project-structure.mdxresouce→resourceindocs/01-app/01-getting-started/04-linking-and-navigating.mdxaccidentanlly→accidentallyindocs/01-app/01-getting-started/08-server-and-client-components.mdxswichter→switcherindocs/01-app/01-getting-started/10-caching-and-revalidating.mdxType of Change