[RSDK-3640] Implement More APP API's #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
stuqdog
requested changes
Aug 10, 2023
src/viam/app/app_client.py
Outdated
|
|
||
| async def remove_role(self): | ||
| raise NotImplementedError() | ||
| # TODO: The name of a fragment HAS to be updated if any updates to its config and/or public status are being made. |
There was a problem hiding this comment.
what is the "TODO" here? can we remove or update this?
There was a problem hiding this comment.
I thought it was kind of weird that if I want to update a fragment, I have to also change its name (or pass its current name to keep it the same). This is an upstream issue but I feel like it should be made optional
…inter dereference' error.
stuqdog
reviewed
Aug 14, 2023
|
|
||
| async def get_user_id_by_email(self): | ||
| async def _get_organization_id(self) -> str: | ||
| return self._organization_id if self._organization_id else await self._request_organization_id() |
There was a problem hiding this comment.
Where are we setting it? It seems like everything asks for org id by calling this method, but this method only returns a value, it doesn't set a parameter. Is there some call site that sets the param? It definitely looks to me like we'll have to do the async work every time here.
stuqdog
approved these changes
Aug 14, 2023
njooma
approved these changes
Aug 17, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements and tests all of the remaining APP API's that DON'T return a 'nil pointer dereference' error from our App server. Not included in this PR are the "TODO" comments explaining when/how this error occurs.