Skip to content

More docstrings clarification #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2023
Merged

More docstrings clarification #390

merged 3 commits into from
Aug 17, 2023

Conversation

andf-viam
Copy link
Contributor

@andf-viam andf-viam commented Aug 17, 2023

  • Tweaking upload method intro description to clarify which tab where (assuming for file_upload and file_upload_from_path -- please confirm!). Also using upload X to the app instead of sync with - these commands are uni-directional (i.e. send up, not then-also-bring-down).
  • Assuming remove_tags_from_binary_data_by_filter should be untag, this is an educated guess.
  • One more typo

Hope this helps!

- Tweaking upload method intro description to clarify which tab where. Assuming for `file_upload` and `file_upload_from_path` -- please confirm!
- Assuming `remove_tags_from_binary_data_by_filter` should be `untag`, this is an educated guess.

Hope this helps!
@andf-viam andf-viam requested a review from a team as a code owner August 17, 2023 17:11
@andf-viam andf-viam merged commit 13a8d88 into main Aug 17, 2023
@andf-viam andf-viam deleted the andf-viam-patch-1 branch August 17, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants