RSDK-4197: Add support for Flat Tensors in Python SDK #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 6, 2023 16:43
… np conversion bidirectionally (first draft); changed client and service to use new updated params and new utils
hexbabe
commented
Sep 7, 2023
stuqdog
reviewed
Sep 8, 2023
src/viam/utils.py
Outdated
|
|
||
| ndarrays: Dict[str, NDArray] = dict() | ||
| for name, flat_tensor in flat_tensors.tensors.items(): | ||
| property_name = flat_tensor.WhichOneof("tensor") or flat_tensor.WhichOneof(b"tensor") # sus... |
There was a problem hiding this comment.
This seems fine to me? Agreed it's awkward but that's what the method calls for :/
Probably good to remove the comment here before we merge, also.
There was a problem hiding this comment.
Do you have more info than I on why the method accepts a bytes and non-bytes str literal of the same str?
There was a problem hiding this comment.
I do not! but it is what it is 🤷
added 2 commits
September 8, 2023 12:47
…sor_data_class dict to outside of double nested helper to optimize instantiation; fixed timeout typo
hexbabe
commented
Sep 11, 2023
| data = ndarray.flatten() | ||
| if tensor_data_class == FlatTensorDataInt8 or tensor_data_class == FlatTensorDataUInt8: | ||
| data = data.tobytes() # as per the proto, int8 and uint8 are stored as bytes | ||
| elif tensor_data_class == FlatTensorDataInt16 or tensor_data_class == FlatTensorDataUInt16: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use numpy arrays as the backing data struct instead of dicts for mlmodel
Test plan notes:
EDGE FlatTensors without any tensors
FlatTensors with one tensor (say.. double type)
google.protobuf.internal.containers.RepeatedScalarFieldContainerFlatTensors with two tensors (double type, float type)
google.protobuf.internal.containers.RepeatedScalarFieldContainerCheck all flat tensor data types in bundles of appropriate types