Fix simple module, update readme #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpertsov
reviewed
Nov 2, 2023
examples/simple_module/client.py
Outdated
| creds = Credentials(type="<your authentication type here>", payload="<your authentication payload here>") | ||
| opts = RobotClient.Options(refresh_interval=0, dial_options=DialOptions(credentials=creds), log_level=logging.DEBUG) | ||
| return await RobotClient.at_address("<your robot uri here>", opts) | ||
| # creds = Credentials(type="<your authentication type here>", payload="<your authentication payload here>") |
There was a problem hiding this comment.
assuming you meant to uncomment nvm i see we are just changing to insecure, let's remove then
Suggested change
| # creds = Credentials(type="<your authentication type here>", payload="<your authentication payload here>") |
There was a problem hiding this comment.
Might have to un-import Credentials now that we're not using it anymore.
There was a problem hiding this comment.
ah that's unintentional, will revert that part
purplenicole730
approved these changes
Nov 2, 2023
examples/simple_module/client.py
Outdated
| creds = Credentials(type="<your authentication type here>", payload="<your authentication payload here>") | ||
| opts = RobotClient.Options(refresh_interval=0, dial_options=DialOptions(credentials=creds), log_level=logging.DEBUG) | ||
| return await RobotClient.at_address("<your robot uri here>", opts) | ||
| # creds = Credentials(type="<your authentication type here>", payload="<your authentication payload here>") |
There was a problem hiding this comment.
Might have to un-import Credentials now that we're not using it anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated client as well
as part of testing, found a small issue with our validation code so fixed that as well
also made all the logs info so it'll show up even if not in debug mode
@dannenberg think this is what you wanted