Skip to content

RSDK-5637 Remove mime type inference of PCD within get_image #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

RSDK-5637 Remove mime type inference of PCD within get_image #481

merged 1 commit into from
Nov 6, 2023

Conversation

hexbabe
Copy link
Member

@hexbabe hexbabe commented Nov 3, 2023

@hexbabe hexbabe marked this pull request as ready for review November 3, 2023 15:06
@hexbabe hexbabe requested a review from a team as a code owner November 3, 2023 15:06
@hexbabe hexbabe requested a review from benjirewis November 3, 2023 15:06
kharijarrett
kharijarrett approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@kharijarrett kharijarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% LGTM. GetImage is for 2D images only, this should never be allowed to return a pcd

@bazile-clyde
Copy link

100% LGTM. GetImage is for 2D images only, this should never be allowed to return a pcd

For the record, I agree!

@bazile-clyde bazile-clyde self-requested a review November 3, 2023 15:19
@hexbabe
Copy link
Member Author

hexbabe commented Nov 3, 2023

hmm, now I’m wondering if any Python (lidar maybe?) modules depend on this functionality and if its breaking anything

@hexbabe hexbabe requested a review from cheukt November 6, 2023 19:13
@hexbabe hexbabe merged commit d3ea4fd into viamrobotics:main Nov 6, 2023
@hexbabe hexbabe deleted the RSDK-5637 branch November 6, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kharijarrett kharijarrett kharijarrett approved these changes

@bazile-clyde bazile-clyde bazile-clyde approved these changes

@cheukt cheukt cheukt approved these changes

@njooma njooma Awaiting requested review from njooma

@benjirewis benjirewis Awaiting requested review from benjirewis benjirewis is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hexbabe @bazile-clyde @kharijarrett @cheukt