Skip to content

DATA-1988 - Make file ext manadatory for binary_data_capture_upload, update docstrings #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2023
Merged

DATA-1988 - Make file ext manadatory for binary_data_capture_upload, update docstrings #483

merged 1 commit into from
Nov 16, 2023

Conversation

stuqdog
Copy link
Member

@stuqdog stuqdog commented Nov 6, 2023

No description provided.

@stuqdog stuqdog requested a review from a team as a code owner November 6, 2023 15:16
@stuqdog stuqdog changed the title RSDK-4527 - Make file ext manadatory for binary_data_capture_upload, update docstrings DATA-1988 - Make file ext manadatory for binary_data_capture_upload, update docstrings Nov 6, 2023
dgottlieb
dgottlieb approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@dgottlieb dgottlieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I suppose we'll have to note this is backwards breaking?

maximpertsov
maximpertsov suggested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@maximpertsov maximpertsov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly prefer keeping this as named argument but making it mandatory - we have a lot of position arguments and this will minimize breakage to existing code.

Ignore me, I forgot how python works - LGTM

@maximpertsov maximpertsov self-requested a review November 8, 2023 16:18
@stuqdog stuqdog merged commit a638bad into viamrobotics:main Nov 16, 2023
@stuqdog stuqdog deleted the add-file-ext-parameter branch November 16, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgottlieb dgottlieb dgottlieb approved these changes

@maximpertsov maximpertsov maximpertsov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuqdog @dgottlieb @maximpertsov