Skip to content

RSDK-4941 - use org api key in examples #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

stuqdog
Copy link
Member

@stuqdog stuqdog commented Nov 6, 2023

No description provided.

@stuqdog stuqdog requested a review from a team as a code owner November 6, 2023 16:24
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why logging was imported if it wasn't needed? Otherwise, LGTM!

@stuqdog
Copy link
Member Author

stuqdog commented Nov 6, 2023

I wonder why logging was imported if it wasn't needed? Otherwise, LGTM!

@purplenicole730 I think it was being used before in creating the options (log_level=logging.DEBUG) but the with_api_key method just goes with defaults.

@purplenicole730
Copy link
Member

I wonder why logging was imported if it wasn't needed? Otherwise, LGTM!

@purplenicole730 I think it was being used before in creating the options (log_level=logging.DEBUG) but the with_api_key method just goes with defaults.

Oh there it is! I forgot that we set log_level in the options and was more focused on the function change. Ignore me, haha 😁

@stuqdog stuqdog merged commit 6eecb2d into viamrobotics:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants