-
Notifications
You must be signed in to change notification settings - Fork 65
Update builtin.{txt,jax} #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update builtin.{txt,jax} #1471
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8adcb39
Update builtin.{txt,jax}
mityu d06b2c4
Fix by review
mityu 80e6f21
Remove use of 「もし」
mityu 5d744ae
Add missing 「オブジェクト」
mityu 6f6c33a
Fix by review
mityu a49bbc9
Fix by review
mityu e379046
Update builtin.jax
mityu 2f4da4f
Improve a translation
mityu d4b2a28
Fix by review
mityu f5d5eef
Improve translations by review
mityu 6d32962
Improve translations in builtin.jax
mityu 9c7ffc3
Revert "Improve translations in builtin.jax"
mityu 8f855ab
Update builtin.{txt,jax}
mityu 9fac19a
Do not translate output of string()
mityu d357a6b
Fix by review
mityu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あたりに訳そうかと思います。他の訳文の提案でも構いません。
数個上の「文字列」の項も折り返していますがそれは補足情報の途中のところですし、他の箇所の
{日本語メッセージの場合:...
の部分でもメッセージ途中で折り返したりしているので、こっちも折り返した方が良いのか...?と悩んだのですが、辞書のダンプっぽい形式のものの途中で改行を入れるのもなんだか気持ち悪い気がしてしまい...。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いやー、コードブロックでもないし、やっぱり折り返した方が良い気がしてきましたね...。
他に参考になるような箇所があれば良いんですがなかなか見つからない...。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1つ目:
列挙型
で 👍 (vim9class.jax ではそう訳してます)2つ目:
折り返して良いと思います。
以下、原文に対しての意見。
・
{expr} type
のネストがタブ1つなのがもったいない。空白4つにすればいいのに...・将来的に、それでも足りなくなれば、
result ~
の前の空白も切り詰める...とかThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
えーと、これはつまりこういう変更をいれて追加で push しておけば OK ということでよろしいです?(すでに Approved がついているので一応確認です)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
はい、そうです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この表は
string()
の結果を示しており、例えば、を実行すると
class SomeName
になります。結果の欄の
class
,object of
,enum
は翻訳対象ではありません。(例えば https://github.com/vim/vim/blob/cc7597c1edf478ad912d45b27f17175236f9791e/src/vim9class.c#L3855 )
改行を入れるかどうかは、
string()
の結果をそのまま示すという意味では改行しない方がよさそうに思いました。(もし改行を入れるなら、原文に入れてからの方がよいかと。)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほど。その通りですね。
class
,object of
は昔の私がやっちゃってました。 @mityu お手数ですがあわせて修正お願いします。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
了解ですー
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
対応しました。