Skip to content

Update builtin.{txt,jax} #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024
Merged

Update builtin.{txt,jax} #1518

merged 2 commits into from
May 7, 2024

Conversation

h-east
Copy link
Member

@h-east h-east commented May 5, 2024

No description provided.

Copy link
Member

@mityu mityu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です。
一点だけ、強いて挙げるならここが少し気になったなあ、という点を挙げてはいますが、このままでも良いかと思います。

doc/builtin.jax Outdated
@@ -9738,6 +9738,10 @@ synconcealed({lnum}, {col}) *synconcealed()*
synconcealed(lnum, 5) [1, 'X', 2]
synconcealed(lnum, 6) [0, '', 0]

Note: 構文とマッチのハイライトは |syntax-vs-match| という 2 つ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

強いて挙げるなら、ここは「|syntax-vs-match| という」よりも「|syntax-vs-match| にあるような」のように方が日本語としての通りはよくなるように思います。が、直訳ベースの訳からは遠のいてしまうので、うーんという感じです。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mityu さんの訳に1票。
(原文に寄せるなら「構文とマッチのハイライトは 2 つの異なるメカニズムである |syntax-vs-match| ため」になるかと思いますが。)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

サジェスト踏まえて修正しました。どうでっしゃろ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おー、良いですね。

@h-east h-east merged commit 38b9d11 into master May 7, 2024
3 checks passed
@h-east h-east deleted the hh-update-builtin branch May 7, 2024 16:16
@h-east
Copy link
Member Author

h-east commented May 7, 2024

Thanks for the suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants