Skip to content

Update usr_52.{txt,jax} #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Update usr_52.{txt,jax} #1557

merged 1 commit into from
Jun 8, 2024

Conversation

h-east
Copy link
Member

@h-east h-east commented Jun 1, 2024

52.6章のhighlight-yank プラグインのサンプルコードはインデントを整理したほうが良いと思う。
(各行頭タブ1つで以降は2スペースインデント?)

Copy link
Member

@mityu mityu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です。
一応1箇所コメントはしてありますが、正直自分もこのままでも良いかなとも思っているので、このままで良いと思われたならこのまま変更なしでマージしちゃってください。

Comment on lines +348 to +349
Vim には、Vim9 script で記述されたコメントプラグイン |comment-install| が付属
しています。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここも下にある |add-plugin| のところと同じ感じで、タグを後置して「Vim には、Vim9 script で記述されたコメントプラグインが付属しています。|comment-install|」としても良いかな...?と思いました。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今回はこのままにします。
ただ、指摘の意図も分かるので、原文に変更を依頼します。
typo報告スレにpatch

@h-east h-east merged commit d84aed2 into master Jun 8, 2024
3 checks passed
@h-east h-east deleted the hh-update-usr_52 branch June 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants