Skip to content

Update channel.{txt,jax} #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2024
Merged

Update channel.{txt,jax} #1564

merged 3 commits into from
Jun 15, 2024

Conversation

h-east
Copy link
Member

@h-east h-east commented Jun 9, 2024

お気持ち:

  • 同じような修正(組み込み関数の説明の最後に戻り値の型情報を追加)が続くので間違えないようにしなきゃ。。3回見直したけど、この対応を他のファイルにも反映するのしんどいなぁ。。
  • 関数間の間隔が今回の変更分で1行または2行にブレているけど、今は気にしないでおこう。後で正規表現で一気にチェックしよう。

tsuyoshicho
tsuyoshicho approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@tsuyoshicho tsuyoshicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指摘点はありますが、LGTMです

@h-east h-east requested a review from tsuyoshicho June 10, 2024 14:07
@mityu
Copy link
Member

mityu commented Jun 15, 2024

おっとすみません、sign.txt の方 approve しに行ったつもりが、間違えてこっちで2度目の approve しに来てしまいました

@h-east h-east merged commit 3a840d5 into master Jun 15, 2024
3 checks passed
@h-east h-east deleted the hh-update-channel branch June 15, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuyoshicho tsuyoshicho tsuyoshicho approved these changes

@mityu mityu mityu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-east @mityu @tsuyoshicho