Skip to content

Update builtin.{txt,jax} #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

Update builtin.{txt,jax} #2062

merged 3 commits into from
May 9, 2025

Conversation

h-east
Copy link
Member

@h-east h-east commented Apr 30, 2025

No description provided.

Copy link
Contributor

@tsuyoshicho tsuyoshicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントしました。

inoremap <Tab> <Cmd>call CustomComplete()<CR>
<
Return type: list<list<any>>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ、元から空行2行じゃないんですね(それも徹底されてるルールなのか不明ですけど)

doc/builtin.jax Outdated
col({expr} [, {winid}]) 数値 カーソルかマークのカラムバイトインデッ
クス
complete({startcol}, {matches}) なし 挿入モード補完を設定する
complete_add({expr}) 数値 補完候補を追加する
complete_check() 数値 補完中に押されたキーをチェックする
complete_info([{what}]) 辞書 現在の補完情報を取得
complete_match([{lnum}, {col}]) リスト 補完桁とトリガーテキストを取得
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note and Suggestion
このままでも大丈夫とは思います。

complete_match([{lnum}, {col}]) List get completion column and trigger text

ただ、 completion は column と trigger text 両方とかかわりそうなので

complete_match([{lnum}, {col}])	リスト	補完の文字桁とトリガーテキストを取得

Suggested change
complete_match([{lnum}, {col}]) リスト 補完桁とトリガーテキストを取得
complete_match([{lnum}, {col}]) リスト 補完桁と補完のトリガーテキストを取得

のような明確化してもいいのかなとは思いました。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本文も踏まえて「補完のカラムとトリガー文字列を取得」にしました。

Copy link
Contributor

@tsuyoshicho tsuyoshicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approveではあったので、やりなおし

@h-east h-east requested a review from tsuyoshicho May 6, 2025 13:15
Copy link
Member

@mityu mityu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1箇所のみ。他は良さげです。

@h-east h-east merged commit 2793388 into vim-jp:master May 9, 2025
2 checks passed
@h-east h-east deleted the update-builtin branch May 9, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants