fix text and char column php code args #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39 started setting
character_set
andcollation
properties which surfaced a problem that already existed insrc/Schema/Column/TextTrait.php
A leading comma would be added to the generated constructor:
php-mysql-engine/src/Schema/Column/TextTrait.php
Line 14 in 2e8b092
Also noticed a potential bug in #39 in
CharacterColumn
arg building:php-mysql-engine/src/Schema/Column/CharacterColumn.php
Lines 70 to 76 in 21a606f
If only
collation
was defined in that implementation, the value ofcollation
would be used for thecharacter_set
argument in the constructorThis PR:
test
andvarchar
CHARACTER SET
andCOLLATE