Skip to content

fix(coverage): improved go.mod file search #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025
Merged

Conversation

vladopajic
Copy link
Owner

@vladopajic vladopajic commented May 15, 2025

searching for go.mod with filepath.Walk is not ideal as it is depth first search, which may returngo.mod files in directories that are lexicographical before go.mod file.

with this pr, go.mod will be searched in root directory and filepath.Walk will be used as fallback.

should fix: #190

Copy link

go-test-coverage report:

File coverage threshold (100%) satisfied:	PASS
Total coverage threshold (100%) satisfied:	PASS
Total test coverage: 100% (668/668)

Current tests coverage has not changed.

@vladopajic vladopajic merged commit e459ad4 into main May 15, 2025
9 checks passed
@vladopajic vladopajic deleted the go-mod-search-improv branch May 15, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not find file
1 participant