Skip to content

chore: minor improvements #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2025
Merged

chore: minor improvements #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3890f21
minor improvements
vladopajic May 17, 2025
6a17501
fix
vladopajic May 17, 2025
67936d8
lint fix
vladopajic May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/testcoverage/badge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func generateAndSaveBadge(w io.Writer, cfg Config, totalCoverage int) error {
buffer := &bytes.Buffer{}
out := bufio.NewWriter(buffer)

// `out` writer is used as temporall buffer, which will be finally
// `out` writer is used as temporary buffer, which will be finally
// written to `w` in this defer call
defer func() {
out.Flush()
Expand Down
8 changes: 5 additions & 3 deletions pkg/testcoverage/check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ func Check(wout io.Writer, cfg Config) (bool, error) {
}

if cfg.LocalPrefixDeprecated != "" { // coverage-ignore
reportGHWarning(w, "Deprecated option",
"local-prefix option is deprecated since v2.13.0, you can safely remove setting this option")
//nolint:lll // relax
msg := "`local-prefix` option is deprecated since v2.13.0, you can safely remove setting this option"
logger.L.Warn().Msg(msg)
reportGHWarning(w, "Deprecated option", msg)
}
}

Expand Down Expand Up @@ -152,7 +154,7 @@ func loadBaseCoverageBreakdown(cfg Config) ([]coverage.Stats, error) {

stats, err := coverage.StatsDeserialize(data)
if err != nil {
return nil, fmt.Errorf("parsing file failed: %w", err)
return nil, fmt.Errorf("deserializing stats file failed: %w", err)
}

return stats, nil
Expand Down
Loading