Skip to content

Add a basic sample template for simple samples #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

tianhao64
Copy link
Contributor

The current sample template treat sample as a class. It work well for complex samples when setup and cleanup are needed and some logic is in place. However it's not needed for basic samples which just demo one or two API usage. The code snippets with self. are also hard to use for users who just want to copy/paste to their script. Creating another template for basic samples.

Other example of such simple samples are: https://github.com/vmware/vsphere-automation-sdk-python/tree/master/samples/vmc/tasks

Signed-off-by: Tianhao He [email protected]

@tianhao64 tianhao64 requested review from kmruddy and pgbidkar April 10, 2019 07:17
Copy link
Contributor

@pgbidkar pgbidkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tianhao64 tianhao64 merged commit 90d5c09 into vmware:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants