New sample for appliance Health #177

shwetapurohit · 2019-08-08T06:50:06Z

Adding new sample to appliance .Sample demonstrates getting Health messages for various health items .Retrieves Health messages details from vCenter and prints the data.

vmwclabot · 2019-08-08T06:50:08Z

@aspurohit, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 1b7897f must be signed by [email protected]

vmwclabot · 2019-08-08T10:14:08Z

@aspurohit, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 1b7897f must be signed by [email protected]
Commit 296c0b5 must be signed by [email protected]

vmwclabot · 2019-08-08T10:38:25Z

@aspurohit, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 1b7897f must be signed by [email protected]
Commit 296c0b5 must be signed by [email protected]
Commit d178490 must be signed by [email protected]

vmwclabot · 2019-08-08T11:01:37Z

@aspurohit, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 1b7897f must be signed by [email protected]
Commit 296c0b5 must be signed by [email protected]

samples/vsphere/appliances/health_messages.py

pgbidkar · 2019-08-08T10:58:59Z

samples/vsphere/appliances/health_messages.py

+"""
+
+__author__ = 'VMware, Inc.'
+__copyright__ = 'Copyright 2017 VMware, Inc. All rights reserved.'


Copy right year

pgbidkar · 2019-08-08T10:59:54Z

samples/vsphere/appliances/health_messages.py

+
+class HealthMessages(object):
+    """
+    Demonstrates getting Health messages for various health items


Can you explain what are health items?

Demonstrates getting Health messages for memory, storage and cpu

Please check if this change is taken care?

pgbidkar · 2019-08-08T11:00:43Z

samples/vsphere/appliances/health_messages.py

+        args = sample_util.process_cli_args(parser.parse_args())
+        self.item = args.item
+
+    # Connect to vAPI services


FIx this indentation

pgbidkar · 2019-08-08T11:04:51Z

samples/vsphere/appliances/health_messages.py

+
+    def run(self):
+        message_list = self.health_client.messages(self.item)
+        notification_message = Notification()


This is not required I guess

pgbidkar · 2019-08-08T11:05:29Z

samples/vsphere/appliances/health_messages.py

+        if not message_list:
+            print("No health alarms for : " + self.item)
+        else:
+            for notification_message in message_list:


for message in message_list

pgbidkar · 2019-08-08T11:05:50Z

samples/vsphere/appliances/health_messages.py

+            print("No health alarms for : " + self.item)
+        else:
+            for notification_message in message_list:
+                print("Alert time : {}".format(notification_message.time))


message.time

pgbidkar · 2019-08-08T11:06:15Z

samples/vsphere/appliances/health_messages.py

+            for notification_message in message_list:
+                print("Alert time : {}".format(notification_message.time))
+                print("Alert message Id: " + notification_message.id)
+                local_message = notification_message.message


message.message

pgbidkar · 2019-08-08T11:06:56Z

samples/vsphere/appliances/health_messages.py

+                print("Alert time : {}".format(notification_message.time))
+                print("Alert message Id: " + notification_message.id)
+                local_message = notification_message.message
+                def_message = local_message.default_message


Make variable name def_message more descriptive

vmwclabot · 2019-08-08T11:26:51Z

@aspurohit, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 1b7897f must be signed by [email protected]
Commit 296c0b5 must be signed by [email protected]

pgbidkar · 2019-08-08T11:34:22Z

samples/vsphere/appliances/health_messages.py

+
+class HealthMessages(object):
+    """
+    Demonstrates getting Health messages for various health items


Demonstrates getting Health messages for memory, storage and cpu

pgbidkar · 2019-08-08T11:34:52Z

samples/vsphere/appliances/health_messages.py

+
+    def run(self):
+        message_list = self.health_client.messages(self.item)
+        message = Notification()


This is not required

pgbidkar · 2019-08-08T11:35:08Z

samples/vsphere/appliances/health_messages.py

+    def run(self):
+        message_list = self.health_client.messages(self.item)
+        message = Notification()
+        msg = LocalizableMessage()


this is also not required

pgbidkar · 2019-08-08T11:41:26Z

samples/vsphere/appliances/health_messages.py

+
+from samples.vsphere.common import sample_cli
+from samples.vsphere.common import sample_util
+from samples.vsphere.common import vapiconnect


All three imports can be combined

from samples.vsphere.common import (sample_cli, sample_util, vapiconnect)

vmwclabot · 2019-08-08T11:49:05Z

@aspurohit, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 1b7897f must be signed by [email protected]
Commit 296c0b5 must be signed by [email protected]
Commit b54b0fa must be signed by [email protected]

vmwclabot · 2019-08-09T09:55:33Z

@aspurohit, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 1b7897f must be signed by [email protected]
Commit 296c0b5 must be signed by [email protected]

samples/vsphere/appliances/health_messages.py

vmwclabot · 2019-08-13T06:31:50Z

@aspurohit, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 1b7897f must be signed by [email protected]
Commit 296c0b5 must be signed by [email protected]
Commit be0ad5f must be signed by [email protected]

samples/vsphere/appliances/health_messages.py

pgbidkar · 2019-08-13T07:26:38Z

samples/vsphere/appliances/health_messages.py

+
+class HealthMessages(object):
+    """
+    Demonstrates getting Health messages for various health items


Please check if this change is taken care?

vmwclabot · 2019-08-13T07:52:25Z

@aspurohit, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 1b7897f must be signed by [email protected]

pgbidkar

LGTM
Hi @tianhao64 , Please review

tianhao64

Couple of minor issues.

samples/vsphere/appliances/health_messages.py

vmwclabot · 2019-08-13T16:37:44Z

@aspurohit, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 1b7897f must be signed by [email protected]
Commit 4234466 must be signed by [email protected]

samples/vsphere/appliances/health_messages.py

updated Health appliance sample cleaned up health appliance sample Signed-off-by: aspurohit <[email protected]> Removed unused objects Signed-off-by: aspurohit <[email protected]> modified as per sample_template_basic updated as per review comments updated the sample as per review comments updated the sample as per import standards

vmwclabot added the dco-required label Aug 8, 2019

shwetapurohit force-pushed the master branch from d178490 to 6358375 Compare August 8, 2019 11:01

pgbidkar reviewed Aug 8, 2019

View reviewed changes

shwetapurohit force-pushed the master branch from 6358375 to e2d74b5 Compare August 8, 2019 11:26

pgbidkar reviewed Aug 8, 2019

View reviewed changes

shwetapurohit force-pushed the master branch from e2d74b5 to b54b0fa Compare August 8, 2019 11:49

shwetapurohit force-pushed the master branch from b54b0fa to 099a92d Compare August 9, 2019 09:55

tianhao64 suggested changes Aug 9, 2019

View reviewed changes

pgbidkar reviewed Aug 13, 2019

View reviewed changes

shwetapurohit force-pushed the master branch from be0ad5f to 22b8b28 Compare August 13, 2019 07:52

pgbidkar approved these changes Aug 13, 2019

View reviewed changes

tianhao64 suggested changes Aug 13, 2019

View reviewed changes

tianhao64 reviewed Aug 14, 2019

View reviewed changes

samples/vsphere/appliances/health_messages.py Outdated Show resolved Hide resolved

shwetapurohit force-pushed the master branch from 4234466 to 08a6c02 Compare August 14, 2019 07:07

vmwclabot removed the dco-required label Aug 14, 2019

tianhao64 merged commit 206ca3d into vmware:master Aug 20, 2019

New sample for appliance Health #177

New sample for appliance Health #177

Uh oh!

Conversation

shwetapurohit commented Aug 8, 2019

Uh oh!

vmwclabot commented Aug 8, 2019

Uh oh!

vmwclabot commented Aug 8, 2019

Uh oh!

vmwclabot commented Aug 8, 2019

Uh oh!

vmwclabot commented Aug 8, 2019

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vmwclabot commented Aug 8, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vmwclabot commented Aug 8, 2019

Uh oh!

vmwclabot commented Aug 9, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vmwclabot commented Aug 13, 2019

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vmwclabot commented Aug 13, 2019

Uh oh!

pgbidkar left a comment

Choose a reason for hiding this comment

Uh oh!

tianhao64 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vmwclabot commented Aug 13, 2019

Uh oh!

Uh oh!

Uh oh!