Skip to content

Sample to demonstrate Cert Verification while connecting to vCenter s… #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Conversation

pgbidkar
Copy link
Contributor

Sample to demonstrate Cert Verification while connecting to vCenter server

Signed-off-by: pgbidkar [email protected]

parser = build_arg_parser()
parser.add_argument('-cpath', '--cert_path',
action='store',
help='Verify vCenter Server certificate')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help message should be more precise. The requests documentation says"path to a CA_BUNDLE file or directory with certificates of trusted CAs". How about we use the same?

http://docs.python-requests.org/en/master/user/advanced/#ca-certificates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree... I will modify this

@vmwclabot
Copy link

@pgbidkar, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

…ge help message for cert_path argument

Signed-off-by: Pavan Bidkar [email protected]

Sample to demonstrate Cert Verification while connecting to vCenter server Updated README.md for common package description

Signed-off-by: pgbidkar <[email protected]>

Sample to demonstrate Cert Verification while connecting to vCenter server
Signed-off-by: Pavan Bidkar [email protected]

Signed-off-by: pgbidkar <[email protected]>

Modified cert_path argument help message to align with requests package help message for cert_path argument
Signed-off-by: Pavan Bidkar [email protected]

Signed-off-by: pgbidkar <[email protected]>
@tianhao64 tianhao64 merged commit 2d232fd into vmware:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants