Adding ESXPASSWORD as commandline argument. ESXPassword cannot be har… #6
Conversation
|
@pgbidkar, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
| @@ -103,4 +104,8 @@ def build_arg_parser(): | |||
| action='store', | |||
| help='NFS Server IP to setup datastore for samples run.' | |||
| 'If not passed as argument, update testbed.py file') | |||
| parser.add_argument('-epassword', '--esxpassword', | |||
There was a problem hiding this comment.
@pgbidkar do you want to move this up next to e2? Keep a space in between just to be consistent. Also it seems the short version of the command is not that short. How about -ep, or perhaps we can just use the full command?
There was a problem hiding this comment.
Moved after e2. Making short argument to -epass instead just to avoid ambiguous if we add -p as argument in future.
Added space.
|
@pgbidkar, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
There was a problem hiding this comment.
Can you squash the commits to one, so we keep a cleaner history? Here is how: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit
Also you need to sign off the commit by adding "Signed-off-by: Pavan Bidkar [email protected]" at the bottom of the commit message.
| @@ -39,6 +39,7 @@ def build_arg_parser(): | |||
| -e1, --esxhost1 | |||
| -e2, --esxhost2 | |||
| -n, --nfsserver | |||
| -epass, --esxpassword | |||
|
@pgbidkar, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
|
Rebased and Squashed all commits to single commit |
|
@pgbidkar, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
…dcoded in testbed.py file since ESX doesnt have default password Signed-off-by: Pavan Bidkar <[email protected]> Adding ESXPASSWORD as commandline argument. ESXPassword cannot be hardcoded in testbed.py file since ESX doesnt have default password Signed-off-by: Pavan Bidkar <[email protected]>
Adding ESXPASSWORD as commandline argument. ESXPassword cannot be hardcoded in testbed.py file since ESX doesnt have default password