-
-
Notifications
You must be signed in to change notification settings - Fork 30
Do we need a no-onchange rule? #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Removes linter rule that takes issue with @change events. See vue-a11y/eslint-plugin-vuejs-accessibility#97.
From what I am reading here it is something that is deprecated and meant to target older-browsers. Probably going to turn off in my project by // .eslintrc
"vuejs-accessibility/no-onchange": ["off"], |
I would say that if someone get this issue to fix, it would be removing it from the recommended and add a note about it being deprecated on the documentation of the rule? probably best to include some links about the decision about it's deprecation, at least this issues link. |
I see that we didn't really have much of a discussion about this, but the points presented are very compelling in my opinion, that's why I'm saying this, but if someone has anything against it, we'd like to hear from you. 😄 |
Uh oh!
There was an error while loading. Please reload this page.
Hello. ✋
I was recently trying out Svelte tutorial and encountered the following error.
It's one where you have to use
on:blur
if you are using onlyon:change
.I just remembered that there is a
no-onchange
rule in eslint-plugin-vuejs-accessibility.https://github.com/vue-a11y/eslint-plugin-vuejs-accessibility/blob/master/docs/no-onchange.md
By the way, I also looked at the eslint-plugin-jsx-a11y rules, but they are now deprecated.
Please check the details below.
jsx-eslint/eslint-plugin-jsx-a11y#398
As for React.js, it seems that using the onBlur event will cause a warning on the console.
Is it really a problem to just write onChange? I've been looking into it.
In the WebAim discussion, the following is a "mostly" OK response.
https://webaim.org/discussion/mail_thread?thread=8036#post1
Of the articles referenced in eslint-plugin-vuejs-accessibility, one seems to have an invalid link, and the other link is from around 2004.
It is important to have accessibility measures as a rule, but I think that this rule needs to be updated.
I have two suggestions for the no-onchange rule.
Of course, this is just my opinion from what I've seen, and I'd like to hear opinions from various people. :-)
The text was updated successfully, but these errors were encountered: