Handle non-reactive nulls (#231) #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolhome
force-pushed
the
fix-for-#231
branch
from
700a858 to
a36b3cf
Compare
coolhome
force-pushed
the
fix-for-#231
branch
from
a36b3cf to
c8946b7
Compare
haoqunjiang
requested changes
Feb 18, 2020
src/utils.ts
Outdated
| export function hasOwn(obj: Object | any[], key: string): boolean { | ||
| return hasOwnProperty.call(obj, key); | ||
| return obj !== null && Object.hasOwnProperty.call(obj, key); |
There was a problem hiding this comment.
Better do the obj !== null test in the isReactive function.
And change the obj: Object to obj: object, to make the code clearer.
There was a problem hiding this comment.
@sodatea thanks for the feedback!
haoqunjiang
requested changes
Feb 20, 2020
coolhome
requested review from
haoqunjiang
and removed request for
haoqunjiang
haoqunjiang
previously requested changes
Feb 24, 2020
posva
reviewed
Mar 17, 2020
posva
reviewed
Mar 17, 2020
antfu
reviewed
Jun 3, 2020
Merged
|
This is covered by #311 and no longer an issue in v0.6.1. However, I think we can take the unit-tests. |
antfu
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #231 - Ensure non reactive nulls are supported.
Solution would be to check if the obj is null.