fix(types): ensure correct oldValue typing based on lazy option #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge latest changes from vue-master into fork
|
@LinusBorg this one has now the correct fork, sorry about that. I am not sure regarding the test adjustments which have been done for the vuejs/core@c6a9787 fix. Could you please clarify if I need this as well? |
colinscz
changed the title
|
Hi @cnschwarz, sorry for being late. As Thanks a lot for your contribution. But I am sorry that I would suggest closing this PR after #311 gets merged. |
|
Hi @antfu , thanks for the heads-up, I will keep looking for other issues to fix 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust test cases
corrected typos
adjust method headers and add typings
Fixes #253