fix(watch): update watch options from lazy to immediate #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? My lib vueuse is to provide utils for both Vue 2 and 3. This inconsistent makes me hard to support both versions through the same API. Is there any plan to merge this PR? Let me know if there are any changes needed. Thanks. |
pikax
approved these changes
Apr 24, 2020
|
Is there any plan to merge or improve this PR? |
|
Closing this as it's already being implemented in #311. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with the latest RFC: https://vue-composition-api-rfc.netlify.com/api.html#watch
lazyis renamed toimmediateand default to false.This is a BREAKING CHANGE. Not sure if we should make backward compatible and raise warnings.
Resolves #266