Skip to content

feat: add customRef #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/apis/state.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
export {
reactive,
ref,
customRef,
Ref,
isRef,
toRefs,
Expand Down
1 change: 1 addition & 0 deletions src/reactivity/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export {
} from './reactive'
export {
ref,
customRef,
isRef,
Ref,
createRef,
Expand Down
20 changes: 20 additions & 0 deletions src/reactivity/ref.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,26 @@ export function toRefs<T extends Data = Data>(obj: T): ToRefs<T> {
return ret
}

export type CustomRefFactory<T> = (
track: () => void,
trigger: () => void
) => {
get: () => T
set: (value: T) => void
}

export function customRef<T>(factory: CustomRefFactory<T>): Ref<T> {
const version = ref(0)
return createRef(
factory(
() => void version.value,
() => {
++version.value
}
)
)
}

export function toRef<T extends object, K extends keyof T>(
object: T,
key: K
Expand Down
64 changes: 34 additions & 30 deletions test/v3/reactivity/ref.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {
ref,
customRef,
reactive,
isRef,
toRef,
Expand Down Expand Up @@ -308,34 +309,37 @@ describe('reactivity/ref', () => {
expect(dummyY).toBe(5)
})

// test('customRef', () => {
// let value = 1;
// let _trigger: () => void;

// const custom = customRef((track, trigger) => ({
// get() {
// track();
// return value;
// },
// set(newValue: number) {
// value = newValue;
// _trigger = trigger;
// },
// }));

// expect(isRef(custom)).toBe(true);

// let dummy;
// watchEffect(() => {
// dummy = custom.value;
// }, {flush: 'sync'});
// expect(dummy).toBe(1);

// custom.value = 2;
// // should not trigger yet
// expect(dummy).toBe(1);

// _trigger!();
// expect(dummy).toBe(2);
// });
test('customRef', () => {
let value = 1
let _trigger: () => void

const custom = customRef((track, trigger) => ({
get() {
track()
return value
},
set(newValue: number) {
value = newValue
_trigger = trigger
},
}))

expect(isRef(custom)).toBe(true)

let dummy
watchEffect(
() => {
dummy = custom.value
},
{ flush: 'sync' }
)
expect(dummy).toBe(1)

custom.value = 2
// should not trigger yet
expect(dummy).toBe(1)

_trigger!()
expect(dummy).toBe(2)
})
})