Skip to content

[feature]: add server prefetch hook #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[feature]: add server prefetch hook #80

wants to merge 1 commit into from

Conversation

skyline0705
Copy link

Add serverPrefetch hook for vue-function-api.
In my project, we use this hook for SSR. I have tried it and looks work fine~~

@pi0
Copy link

pi0 commented Sep 26, 2019

Any updates on this?

/cc @LinusBorg @posva @liximomo @TooBug

@posva
Copy link
Member

posva commented Oct 10, 2019

I imagine the PR would need a test.
Since SSR is yet to be added to https://vue-composition-api-rfc.netlify.com/api.html, I'm unsure about. To me it makes sense for this library to implement it as it's for 2.x anyway and also list it on the Readme

@rebeccarich
Copy link

Any update on this one @posva @LinusBorg @liximomo @TooBug? :)
Would be great to get an idea of the roadmap for SSR in this plugin is before we commit to using it in our app. SSR is a requirement for us unfortunately

@michael-zucchetta
Copy link

This would be really helpful for us too and I think it should be added

@pi0
Copy link

pi0 commented Oct 23, 2019

I think we should also ensure no context sharing is happening during concurrent SSR requests. runtimeContext depends on a global reference!

@filrak
Copy link

filrak commented Nov 6, 2019

Any updates on that? I would happily commit my time to push it forward if needed. This feature is a must-have for our project unfortunately ;/

@Akryum
Copy link
Member

Akryum commented Dec 1, 2019

@pi0 I'm not sure this would be a problem, the global variables are used only during setup as it's processing the different components. So for a different request it will be overridden by each component one at a time.

@Akryum
Copy link
Member

Akryum commented Dec 1, 2019

Thanks for the PR @skyline0705 ! Closing in favor of #198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants