Skip to content

Return a more reasonable type for arrays #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Return a more reasonable type for arrays #834

wants to merge 1 commit into from

Conversation

cheese-git
Copy link

Actually it caused a type error in my command line, which complained for missing properties: [Symbol.iterator], [Symbol.unscopables].

Actually it caused a type error in my command line, which complained for missing properties:  [Symbol.iterator], [Symbol.unscopables].
@antfu
Copy link
Member

antfu commented Oct 16, 2021

We would expect to have the types in Vue 3 first and then we do the alignment

https://github.com/vuejs/vue-next/blob/c803eb15ecc0105b947f37c660bdde30457a53b9/packages/reactivity/src/ref.ts#L281

@antfu antfu added the on hold label Oct 16, 2021
@cheese-git
Copy link
Author

Thanks reply, I just opened a PR in vue-next 😄

vuejs/core#4807

@github-actions
Copy link

Stale pull request message

@xiaoxiangmoe
Copy link
Collaborator

@cheese-git This PR will break tuple type

@xiaoxiangmoe
Copy link
Collaborator

Close it now. Reopen it when vue 3 support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants