Skip to content

dx(reactivity): add getter into computed side effect warning #10386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2024
Merged

dx(reactivity): add getter into computed side effect warning #10386

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc0d045
feat(computed): add getter into computed side effect warning
Doctor-wu Feb 23, 2024
0e382e6
feat: format log
Doctor-wu Feb 23, 2024
ee12645
feat: use private getter replace _getter
Doctor-wu Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/reactivity/src/computed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class ComputedRefImpl<T> {
public _cacheable: boolean

constructor(
getter: ComputedGetter<T>,
private getter: ComputedGetter<T>,
private readonly _setter: ComputedSetter<T>,
isReadonly: boolean,
isSSR: boolean,
Expand Down Expand Up @@ -74,7 +74,7 @@ export class ComputedRefImpl<T> {
}
trackRefValue(self)
if (self.effect._dirtyLevel >= DirtyLevels.MaybeDirty_ComputedSideEffect) {
__DEV__ && warn(COMPUTED_SIDE_EFFECT_WARN)
__DEV__ && warn(COMPUTED_SIDE_EFFECT_WARN, `\n\ngetter: `, this.getter)
triggerRefValue(self, DirtyLevels.MaybeDirty_ComputedSideEffect)
}
return self._value
Expand Down